Skip to content

fix: jira changelog.FromValue & changelog.ToValue#2692

Merged
klesh merged 2 commits into
apache:mainfrom
merico-ai:fix-jira-changlog-fromvalue-and-tovalue
Aug 8, 2022
Merged

fix: jira changelog.FromValue & changelog.ToValue#2692
klesh merged 2 commits into
apache:mainfrom
merico-ai:fix-jira-changlog-fromvalue-and-tovalue

Conversation

@mindlesscloud
Copy link
Copy Markdown
Contributor

Summary

fix #2691 [Bug][Jira] Incorrect values of issue_changelogs.from_value and issue_changelogs.to_value

Does this close any open issues?

close #2691

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

changelog.FromValue = ticket.IN_PROGRESS
changelog.ToValue = ticket.IN_PROGRESS
if fromStatus, ok := statusMap[row.FromString]; ok {
changelog.FromValue = fromStatus.StatusCategory
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getStdStatus(fromStatus.StatusCategory)

changelog.FromValue = fromStatus.StatusCategory
}
if toStatus, ok := statusMap[row.ToString]; ok {
changelog.ToValue = toStatus.StatusCategory
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getStdStatus(toStatus.StatusCategory)

Comment thread plugins/jira/tasks/status_collector.go Outdated
},
ApiClient: data.ApiClient,
UrlTemplate: "api/2/status",
UrlTemplate: "api/2/statuses/search",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Api api/2/statuses/search is not existed in jira server version v8.18.1#818001-sha1:765ecc5

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mindlesscloud mindlesscloud force-pushed the fix-jira-changlog-fromvalue-and-tovalue branch from 3e62b9c to 2dca44e Compare August 8, 2022 05:25
Copy link
Copy Markdown
Collaborator

@narrowizard narrowizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 2e06f56 into apache:main Aug 8, 2022
mindlesscloud added a commit that referenced this pull request Aug 8, 2022
* fix: switch back to the API /rest/api/2/status for compatibility

* refactor: rename some csv files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Jira] Incorrect values of issue_changelogs.from_value and issue_changelogs.to_value

3 participants